fix(rn-tester): add missing params when running Android app from watch mode#41979
Closed
szymonrybczak wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@lunaleaps merged this pull request in 43826fa. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Passed
--mode HermesDebugtorun-androidcommand when running from watch mode by pressingaon terminal running a dev server. The flag is the same as in thepackage.json:react-native/packages/rn-tester/package.json
Line 17 in 27f38f6
Changelog:
[INTERNAL] [CHANGED] - Add missing params when running Android app from watch mode by pressing
aTest Plan:
Run
yarn startpressain the watch mode, and Android app should be build and launch correctly.